widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/one_world into lp:widelands

To: mp+222708@xxxxxxxxxxxxxxxxxx
From: Shevonar <infomh@xxxxxxxxxxx>
Date: Tue, 17 Jun 2014 14:50:16 -0000
In-reply-to: <20140610182820.14350.64828.launchpad@ackee.canonical.com>
Reply-to: mp+222708@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

I just took the time to understand and simplify the ResourceDescription::get_editor_pic method. The old behavior to fallback to a resource pic with a negative upper limit was removed since it was not used anyway. If you really don't want it in this commit you are free to revert it.

You answered all the other questions, so I would say ready to merge from my side.
-- 
https://code.launchpad.net/~widelands-dev/widelands/one_world/+merge/222708
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/one_world.

References

[Merge] lp:~widelands-dev/widelands/one_world into lp:widelands
From: SirVer, 2014-06-10