widelands-dev team mailing list archive

[Hans Joachim Desserud <launchpad@xxxxxxxxxxxx>]

Hans Joachim Desserud has proposed merging lp:~hjd/widelands/remove-option into lp:widelands.

Requested reviews:
  Widelands Developers (widelands-dev)

For more details, see:
https://code.launchpad.net/~hjd/widelands/remove-option/+merge/225859

>From what I can see, this option has been the default behaviour since gcc 4.6 and since we don't build with versions prior to 4.7 I believe this option can be removed.

See for details on the change, you used to have to turn it on, but now there's only an option to disable it:
https://gcc.gnu.org/onlinedocs/gcc-4.5.0/gcc/Language-Independent-Options.html
https://gcc.gnu.org/onlinedocs/gcc-4.6.0/gcc/Language-Independent-Options.html
-- 
https://code.launchpad.net/~hjd/widelands/remove-option/+merge/225859
Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands/remove-option into lp:widelands.

=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2014-07-06 08:17:24 +0000
+++ CMakeLists.txt	2014-07-07 16:13:39 +0000
@@ -177,7 +177,6 @@
   add_flag(WL_COMPILE_DIAGNOSTICS "-Wundef")
   add_flag(WL_COMPILE_DIAGNOSTICS "-Wunused")
   add_flag(WL_COMPILE_DIAGNOSTICS "-Wunused-macros")
-  add_flag(WL_COMPILE_DIAGNOSTICS "-fdiagnostics-show-option")
 endif()
 
 # Turn some warnings into errors.