widelands-dev team mailing list archive
-
widelands-dev team
-
Mailing list archive
-
Message #02425
Re: [Merge] lp:~widelands-dev/widelands/bug-999262_part2 into lp:widelands
Review: Needs Fixing
I changed a couple of nits:
- I moved the documentation of your new methods to the header (documentation in .cc files makes less sense. I know that we did that in the past, but for the future, documentation goes into the header).
- Added a disallow_copy_and_assign() to Productionsite.
- One more refactoring suggestion.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-999262_part2/+merge/227348
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-999262_part2.
References