widelands-dev team mailing list archive

[Hans Joachim Desserud <launchpad@xxxxxxxxxxxx>]

Hans Joachim Desserud has proposed merging lp:~hjd/widelands/unused-value into lp:widelands.

Requested reviews:
  Widelands Developers (widelands-dev)

For more details, see:
https://code.launchpad.net/~hjd/widelands/unused-value/+merge/228921

Removed variable assignment happening just before returning (found by scan-build). At the same time I removed what I assume is an older version of this check.


-- 
https://code.launchpad.net/~hjd/widelands/unused-value/+merge/228921
Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands/unused-value into lp:widelands.

=== modified file 'src/ai/defaultai.cc'
--- src/ai/defaultai.cc	2014-07-28 18:03:51 +0000
+++ src/ai/defaultai.cc	2014-07-30 17:51:29 +0000
@@ -1419,10 +1419,7 @@
 	}     // end of mines_ section
 
 	// if there is no winner:
-	// if (proposed_building == INVALID_INDEX) {
 	if (best_building == nullptr) {
-
-		mine = false;
 		return false;
 	}