widelands-dev team mailing list archive

[Tibor Bamhor <tiborb95@xxxxxxxxx>]

Thanks :)

Usually I run codecheck on revisons but on this last one I did not run

I will fix the code, but just few comments:

abundant road - is a road not intensivelly used and is not necessary, start
and ends of the road are connected via other roads. (hence that traversing
on roads, if adjacent flags A and B are connected via two routes, one of
them can be cancelled)

hash:
'x * 1234 + y' cannot collide as long as the size of map is below 1234
(currently the limit is 512 )

random generator:
I dont understand your point, all I want is to add some randomness. These
random numbers should be random and independent for every user. AI runs on
server, or at the end it does not matter where it runs. When I test AI I
test it in network game - all players AI.

2014-10-04 16:14 GMT+02:00 SirVer <SirVer@xxxxxx>:

> Review: Needs Fixing
>
> I finally took a long look at this. Sorry that you needed to wait so long.
> I marked all things as NOCOM(#codereview). Please have a look at the
> comments and fix them.
> --
> https://code.launchpad.net/~widelands-dev/widelands/tibor-ai5/+merge/228762
> You proposed lp:~widelands-dev/widelands/tibor-ai5 for merging.
>

-- 
https://code.launchpad.net/~widelands-dev/widelands/tibor-ai5/+merge/228762
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/tibor-ai5.