widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

> abundant road - is a road not intensivelly used and is not necessary, start
and ends of the road are connected via other roads. (hence that traversing
on roads, if adjacent flags A and B are connected via two routes, one of
them can be cancelled)

please, do not explain stuff here, explain it in the code. that is where the next reader will not understand it otherwise. And as mentioned in the code abundant is the wrong word. I think you mean abandoned (please, use a dictionary). But I like dispensable or simply "find_little_used_road".

> 'x * 1234 + y' cannot collide as long as the size of map is below 1234
(currently the limit is 512 )

I understand that, but it is still not good practise. What if we up the limit one day? your code breaks in unexplainable ways. The data type is uint16 for width and height, so you should deal with it. Also, my suggestion is more efficient: (y << 16) | x.

> random generator:

don't worry. the AI only runs on one machine (and is not simulated synchronizly on all machines), so your code is fine there. I checked.

-- 
https://code.launchpad.net/~widelands-dev/widelands/tibor-ai5/+merge/228762
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/tibor-ai5.