← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/bug-1291904 into lp:widelands

 

Review: Needs Fixing

I went over the code and in general it lgtm. I just do not understand some (most?) of the compatibility cruft that you left in there. For example, buildings and ships should only ever be in savegames, never in maps. Could you elaborate on the individual cases, maybe we can get rid of them too.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1291904/+merge/237128
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1291904.


References