widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Approve

One nit. Otherwise lgtm.

Diff comments:

> === modified file 'debian/rules'
> --- debian/rules	2014-10-19 10:55:07 +0000
> +++ debian/rules	2014-10-25 17:22:19 +0000
> @@ -14,12 +14,9 @@
>  	CFLAGS="$(CFLAGS)" LDFLAGS="$(LDFLAGS)" CPPFLAGS="$(CPPFLAGS)" CXXFLAGS="$(CXXFLAGS)" \
>  	  dh_auto_configure -Scmake -- \
>  		-DWL_PATHS_ARE_ABSOLUTE="true" \
> -		-DWL_INSTALL_PREFIX=/usr \
> -		-DWL_INSTALL_DATADIR=share/games/widelands \
> -		-DWL_INSTALL_BINDIR=games \
> -		-DWL_INSTALL_LOCALEDIR=/usr/share/games/widelands/locale \
> -		-DCMAKE_INSTALL_PREFIX=/usr \
> +		-DWL_INSTALL_DATADIR=/usr/share/games/widelands \
>  		-DCMAKE_BUILD_TYPE=Release 
> +		# -DCMAKE_INSTALL_PREFIX=/usr/games \

either remove or uncomment this line. This way it reads confusing.

>  
>  override_dh_strip:
>  	dh_strip --dbg-package=widelands-dbg
> 
> === modified file 'debian/widelands.install'
> --- debian/widelands.install	2014-03-11 20:57:31 +0000
> +++ debian/widelands.install	2014-10-25 17:22:19 +0000
> @@ -1,3 +1,5 @@
> -usr/games
> +usr/widelands usr/games
> +usr/wl_map_info usr/games
> +usr/wl_render_richtext usr/games
>  usr/share/applications
> -usr/share/icons
> \ No newline at end of file
> +usr/share/icons
> 


-- 
https://code.launchpad.net/~hjd/widelands/debian-reduce-paths/+merge/239646
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/debian.