widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/seafaring-ai into lp:widelands

To: mp+242271@xxxxxxxxxxxxxxxxxx
From: GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>
Date: Sat, 22 Nov 2014 12:02:31 -0000
In-reply-to: <20141119212032.12050.36664.launchpad@ackee.canonical.com>
Reply-to: mp+242271@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

I will have to look at this in detail later, my brain's not working properly today.

Codecheck still comes up with an error, could you please always run codecheck over the complete code base before submitting a merge request? This way, we won't have cosmetic changes in the diff in the future.

I also saw that there are commented out lines of code in the diff, they should go before a merge.
-- 
https://code.launchpad.net/~widelands-dev/widelands/seafaring-ai/+merge/242271
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/seafaring-ai into lp:widelands.

References

[Merge] lp:~widelands-dev/widelands/seafaring-ai into lp:widelands
From: TiborB, 2014-11-19