widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Needs Fixing

I added a bunch of NOCOM(#codereview) comments in the code. I disagree with the has_warehouse method. 

Also you added a bunch of method declarations in lua_bases.h, but did not implement these - I removed them, but that was sloppy. Do you look over the diff when you send something for review?
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1380286/+merge/242975
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1380286.