widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/fonts into lp:widelands

To: mp+238608@xxxxxxxxxxxxxxxxxx
From: GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>
Date: Sat, 06 Dec 2014 12:43:05 -0000
In-reply-to: <20141016185032.13154.59595.launchpad@ackee.canonical.com>
Reply-to: mp+238608@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Resubmit

*ding ding ding* Round 3.

There's one remaining NOCOM comment in src/graphic/text/rt_render.cc [1]. I think it can be deleted, but I put it there just in case.

Regarding the text_layout/text_constants problem, this is being refactored in the fh1 branch anyway - we should revisit the topic and find a solution there.


[1] http://bazaar.launchpad.net/~widelands-dev/widelands/fonts/revision/7259
-- 
https://code.launchpad.net/~widelands-dev/widelands/fonts/+merge/238608
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fonts.

References

[Merge] lp:~widelands-dev/widelands/fonts into lp:widelands
From: GunChleoc, 2014-10-16