widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/rolling_autosave into lp:widelands

To: mp+246061@xxxxxxxxxxxxxxxxxx
From: SirVer <SirVer@xxxxxx>
Date: Mon, 12 Jan 2015 06:38:35 -0000
In-reply-to: <20150111151534.15516.5625.launchpad@ackee.canonical.com>
Reply-to: mp+246061@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

I did review the code and added a bunch of comments. I think there is one bug in there.

> Allow setting of number of files (1-10) in advanced options dialog

I do not think we want users to mess with these settings and having them tunable from the console is a reasonable choice for developer options. I think we should remove the GUI part of this change - do you agree?
-- 
https://code.launchpad.net/~widelands-dev/widelands/rolling_autosave/+merge/246061
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/rolling_autosave.

References

[Merge] lp:~widelands-dev/widelands/rolling_autosave into lp:widelands
From: Tino, 2015-01-11