widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/bug-1412242 into lp:widelands

To: mp+247404@xxxxxxxxxxxxxxxxxx
From: SirVer <SirVer@xxxxxx>
Date: Mon, 26 Jan 2015 07:44:06 -0000
In-reply-to: <20150123110222.23921.74195.launchpad@ackee.canonical.com>
Reply-to: mp+247404@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

The campvis version is used here: http://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/7369/src/logic/campaign_visibility.cc#L34 and references campaigns/campaigns.conf. 

I do not think it needs updating here, only when new campaigns are added maybe? 

I have a tiny nit in the coderview, otherwise lgtm.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1412242/+merge/247404
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1412242.

References

[Merge] lp:~widelands-dev/widelands/bug-1412242 into lp:widelands
From: GunChleoc, 2015-01-23