widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/bug-1380286 into lp:widelands

To: mp+242975@xxxxxxxxxxxxxxxxxx
From: SirVer <SirVer@xxxxxx>
Date: Thu, 12 Feb 2015 20:57:11 -0000
In-reply-to: <20141126204029.15594.95687.launchpad@ackee.canonical.com>
Reply-to: mp+242975@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

I looked at this again right now and went ahead and merged. 

I thought it was a good idea to split the tests into two separates, but it had some code duplication that I decided in the end it is better to keep the test together. I just made the tests a bit tighter by directly comparing the immovables instead of just != nil.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1380286/+merge/242975
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1380286.

References

[Merge] lp:~widelands-dev/widelands/bug-1380286 into lp:widelands
From: TiborB, 2014-11-26