widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/bug-1380287 into lp:widelands

To: mp+252507@xxxxxxxxxxxxxxxxxx
From: GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 11 Mar 2015 10:14:54 -0000
In-reply-to: <20150310201835.8436.59605.launchpad@ackee.canonical.com>
Reply-to: mp+252507@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

I just had a very quick look and it seems to be OK overall - I will have to look at the code properly. One thing though: it might be better to have strings rather than numbers in Lua for the scouting direction. Operating on the pure numbers will make the code hard to read, and also break the code if the C++ enum should change.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1380287/+merge/252507
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1380287 into lp:widelands.

References

[Merge] lp:~widelands-dev/widelands/bug-1380287 into lp:widelands
From: TiborB, 2015-03-10