widelands-dev team mailing list archive
-
widelands-dev team
-
Mailing list archive
-
Message #03866
Re: [Merge] lp:~widelands-dev/widelands/ai-military-changes into lp:widelands
Review: Approve
> :) let make an agreement: If there will be another requests to change something I will change also this, can be?
Pfffff. I changed ts_type to trainingsite_type - I took the time, it took me 36 seconds. Should not have taken you much longer than typing this comment.
I think basic and advanced is fine - it allows for other types to be added in non-awkwardly later and it gives more possibility to grep for it through the source code which will make it easier for future devs to pick up on it.
lgtm.
--
https://code.launchpad.net/~widelands-dev/widelands/ai-military-changes/+merge/253881
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai-military-changes.
References