widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

You found it :)

How about only writing the ships that the player owns as well? We still need the test when loading for older savegames, but not writing it in the first place would be a good idea I think.

Around line 137:

if (ship->get_economy() == temp_economy) {

We could have:

if (ship->get_economy() == temp_economy && ship->get_owner() == player) {

I also spotted a typo in a comment: curent -> current. It would also be good to have a blank space between // and We, makes it easier to read. :)
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1428396/+merge/256857
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1428396 into lp:widelands.