widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Approve

the nocom needs to stay, otherwise lgtm.

Diff comments:

> === modified file 'src/graphic/gl/system_headers.h'
> --- src/graphic/gl/system_headers.h	2015-03-01 09:21:20 +0000
> +++ src/graphic/gl/system_headers.h	2015-07-28 07:15:08 +0000
> @@ -38,6 +38,7 @@
>  #ifdef USE_GLBINDING
>  #   include <glbinding/gl/gl.h>
>  #   include <glbinding/Binding.h>
> +// NOCOM(GunChleoc): Can this go? I could compile and run without this, but I don't know if I'm reaching this part of the code on my machine.

no, that is needed. It fakes that most other gl bindings define gl functions in the public namespace. Add a comment stating this though.

>  using namespace gl;
>  #else
>  #   include <GL/glew.h>


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1375579/+merge/266060
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1375579.