widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

Review: Approve

Code LGTM - Just one question in the diff comments.

Diff comments:

> === modified file 'src/ai/defaultai.cc'
> --- src/ai/defaultai.cc	2015-07-27 20:25:32 +0000
> +++ src/ai/defaultai.cc	2015-08-03 20:07:16 +0000
> @@ -4907,7 +4911,7 @@
>  				defenders_strength = calculate_strength(defenders);
>  
>  				flag = &bld->base_flag();
> -				if (bld->can_attack()) {
> +				if (bld->can_attack() && is_visible) {

Would is_visible && bld->can_attack() be more efficient, since is_visible has already been calculated?

>  					is_attackable = true;
>  				}
>  				owner_number = bld->owner().player_number();


-- 
https://code.launchpad.net/~widelands-dev/widelands/attack_fix/+merge/266796
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/attack_fix.