widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

I have a question regarding this comment:

// NOCOM(#codereview): no need to be static?
std::vector<TribeBasicInfo> Tribes::get_all_tribeinfos()

This function is used in the GameSettingsProvider classes before an egbase is created. Is there a better design than using static for this?

-- 
https://code.launchpad.net/~widelands-dev/widelands/one_tribe/+merge/274832
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/one_tribe.