← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/table_align into lp:widelands

 

Uhm... i looked into this and i think there is much wrong (Checkboxes not reverted, Spinboxes doesn't shown correct, general positioning, numbers do not fit in their position). But i am not a native RTL user so may some one who knows the right positioning should test this.

Anyway: Could you please tell where the tables are used? I assume tables are used for listing elements (like option->language). Are they also used for tabbed windows like buildings menu? I think the headers should also be reordered, shouldn't they? F.e. In "Open new game" choosing a map: LTR Headers are PL/Mapname/Size; in RTL it should be Size/Mapname/PL? Currently it looks strange if the player# are positioned on the left edge (much space between mapname and players).
-- 
https://code.launchpad.net/~widelands-dev/widelands/table_align/+merge/279685
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/table_align into lp:widelands.


References