widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

Code LGTM - just 2 nits. I'll do some testing once the compiler has finished.

Diff comments:

> 
> === modified file 'world/terrains/init.lua'
> --- world/terrains/init.lua	2015-12-05 10:59:02 +0000
> +++ world/terrains/init.lua	2015-12-10 21:13:03 +0000
> @@ -42,12 +42,18 @@
>     -- The following properties are available:
>     -- "arable": Allows building of normal buildings and roads
>     -- "mineable": Allows building of mines and roads
> -   -- "walkable": Allows building of roads only
> +   -- "walkable": Allows building of roads only. Trees don't like this terrain.

It is just a coincidence that our terrains that are only walkable aren't tree friendly. I think it's best to remove that comment - we could configure a tree-friendly walkable terrain in the future.

>     -- "water": Nothing can be built here, but ships and aquatic animals can pass
> -   -- "unreachable": Nothing can be built here (not even immovables), and nothing can walk on it
> +   -- "unreachable": Nothing can be built here, and nothing can walk on it, and nothing will grow.
>     -- "unwalkable": Nothing can be built here, and nothing can walk on it
>     is = "arable",
>  
> +   -- You can add custom additional tooltip entries here.
> +   tooltips = {
> +		-- TRANSLATORS: This is an entry in a terrain tooltip. Try to use 1 word if possible.
> +		_"likes trees",
> +   },
> +
>     -- The list resources that can be found in this terrain.
>     valid_resources = {"water"},
>  
> @@ -237,6 +255,46 @@
>  
>  
>  world:new_terrain_type{
> +   name = "summer_forested_mountain1",
> +   descname = _ "Mountain",

How about calling all tree-friendly mountain terrains "Forested Mountain"? I think this would be an additional help to map editors.

> +   editor_category = "green",
> +   is = "mineable",
> +   -- You can add custom additional tooltip entries here.
> +   tooltips = {
> +		-- TRANSLATORS: This is an entry in a terrain tooltip. Try to use 1 word if possible.
> +		_"likes trees",
> +   },
> +   valid_resources = {"coal", "iron", "gold", "stones"},
> +   default_resource = "",
> +   default_resource_amount = 0,
> +   textures = { pics_dir .. "green/forested_mountain1_00.png" },
> +   dither_layer = 71,
> +   temperature = 50,
> +   humidity = 0.75,
> +   fertility = 0.5,
> +}
> +
> +world:new_terrain_type{
> +   name = "summer_forested_mountain2",
> +   descname = _ "Mountain",
> +   editor_category = "green",
> +   is = "mineable",
> +   -- You can add custom additional tooltip entries here.
> +   tooltips = {
> +		-- TRANSLATORS: This is an entry in a terrain tooltip. Try to use 1 word if possible.
> +		_"likes trees",
> +   },
> +   valid_resources = {"coal", "iron", "gold", "stones"},
> +   default_resource = "",
> +   default_resource_amount = 0,
> +   textures = { pics_dir .. "green/forested_mountain2_00.png" },
> +   dither_layer = 71,
> +   temperature = 50,
> +   humidity = 0.75,
> +   fertility = 0.5,
> +}
> +
> +world:new_terrain_type{
>     name = "sumpf",
>     descname = _ "Swamp",
>     editor_category = "green",


-- 
https://code.launchpad.net/~widelands-dev/widelands/forested_mountain_terrain/+merge/280198
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/forested_mountain_terrain into lp:widelands.