← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/request_supply_opt into lp:widelands

 

Added a comment to your comment, see in diff

Diff comments:

> 
> === modified file 'src/economy/idleworkersupply.cc'
> --- src/economy/idleworkersupply.cc	2015-11-11 09:52:55 +0000
> +++ src/economy/idleworkersupply.cc	2016-01-04 18:44:46 +0000
> @@ -71,6 +71,11 @@
>  	return true;
>  }
>  
> +SupplyProviders IdleWorkerSupply::provider_type(Game &) const

I looked at other examples f.e. here: http://bazaar.launchpad.net/~widelands-dev/widelands/request_supply_opt/view/head:/src/economy/supply.h#L94 and everywhere it is done this way. Also note the 'const' at the end of line, does it not guarantee immutability of Game?

> +{
> +	return SupplyProviders::kFlagOrRoad;
> +}
> +
>  bool IdleWorkerSupply::has_storage() const
>  {
>  	return m_worker.get_transfer();


-- 
https://code.launchpad.net/~widelands-dev/widelands/request_supply_opt/+merge/280193
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/request_supply_opt.


References