← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/fix_overlays into lp:widelands

 

Review: Approve

Works now as expected :-)

The only thing is what Tino already mentioned: A resource could not removed if one choose another resource and hold down Shift while clicking. See https://code.launchpad.net/~janosch-peters/widelands/editor-remove-invalid-resources/+merge/281462/comments/713355

I don't know how it was before, but this is a inconsistent behavior to immovables. Immovables could ever be removed from the map regardless of the kind of actual immovable. F.e. trees could be removed if a ruin is selected by holding down Shift. So we might want to make a new bug about this?

Another side note: For resource water there is only one image in the repo (precisely there are two images: water.png and water4.png which are exactly the same). For other resources there are 4 images used, representing the amount of resource placed on the map. Is this intended or are the small images for water just missing?

Approve functionality for the build help.
-- 
https://code.launchpad.net/~widelands-dev/widelands/fix_overlays/+merge/281641
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fix_overlays.


References