widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Approve

> Checking the return value seems to solve the problem.

Any idea why that should fix it?

one nit, otherwise lgtm.

Diff comments:

> === modified file 'src/io/filesystem/disk_filesystem.cc'
> --- src/io/filesystem/disk_filesystem.cc	2015-01-22 18:14:06 +0000
> +++ src/io/filesystem/disk_filesystem.cc	2016-01-10 12:32:14 +0000
> @@ -278,7 +278,11 @@
>  #ifndef _WIN32
>  	rmdir(fspath.c_str());
>  #else
> -	RemoveDirectory(fspath.c_str());
> +	if (!RemoveDirectory(fspath.c_str())) {
> +		throw wexception

that is weird line breaking. does this not fit into one line?

> +				("%s could not be deleted.",
> +				fspath.c_str());
> +	}
>  #endif
>  }
>  


-- 
https://code.launchpad.net/~widelands-dev/widelands/fix_windows_delete_dir/+merge/282114
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fix_windows_delete_dir.