← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/fix_resource_overlay into lp:widelands

 

Review: Approve correct functionality

Looks very good now :-)

There are some compiler statements/warnings. Because i am not sure to which code they belong, or if they are importand, i write them down here:

1. /src/editor/editorinteractive.cc:134: No space after opening brace allowed!
2. /src/editor/editorinteractive.cc:135: No space after opening brace allowed!
3. /src/editor/editorinteractive.cc:635:9: Warnung: Die Standardfallbehandlung in switch fehlt [-Wswitch-default]
  switch (action) {
4. /src/scripting/lua_map.cc:4483: A space is mandatory after catch/for/if/switch/throw/while.
5. /src/editor/ui_menus/editor_tool_change_resources_options_menu.cc:226: Bad indentation.

Thanks for your work so far :-)

Approving functionality.
-- 
https://code.launchpad.net/~widelands-dev/widelands/fix_resource_overlay/+merge/282680
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fix_resource_overlay.


References