widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

Code LGTM - just one small nit.

Not tested.

Diff comments:

> 
> === modified file 'templates/wiki/edit.html'
> --- templates/wiki/edit.html	2015-04-01 20:01:41 +0000
> +++ templates/wiki/edit.html	2016-01-14 19:36:43 +0000
> @@ -117,14 +117,24 @@
>  				<td  style="vertical-align: middle; text-align: center;"><img src="{{ img.url }}"></td>
>  			</tr>
>  			<tr>
> -				<td class="grey" style="text-align: right;">Code to use in article:</td>
> +				<td class="grey">Code to use in article:</td>
> +				{# Show only one code snippet if the image is greater than 700px #}
>  				{% if img.image.width > 700 %}
> -					<td style="text-align: center;">[![{{img.name}}]({{ img.url }})]({{ img.url }})</td>
> +				<td style="text-align: center;">[![{{img.name}}]({{ img.url }})]({{ img.url }})</td>
> +
> +				{# otherwise give all options #}
>  				{% else %}
>  					<td style="text-align: center;">![{{img.name}}]({{ img.url }})</td>
> +			</tr>
> +				<tr>
> +					<td class="grey">Right aligned:</td>
> +					<td style="text-align: center;">![{{img.name}}]({{ img.url }}){: .right}</td>
> +				</tr>
> +				<tr>
> +					<td class="grey">Left aligned:</td>
> +					<td style="text-align: center;">![{{img.name}}]({{ img.url }}){: .left}</td>
> +				</tr>
>  				{% endif %}
> -			</tr>

Please double-eheck the tr's - is the tr in line 47 still being closed?

> -		
>  		</tbody>
>  		</table>
>  		{% endfor %}


-- 
https://code.launchpad.net/~widelands-dev/widelands-website/iso_date_image_options/+merge/282653
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands-website/iso_date_image_options into lp:widelands-website.