widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

The proposal to merge lp:~widelands-dev/widelands/fix_zip_filesystem into lp:widelands has been updated.

Commit Message changed to:

Use std::shared_ptr to properly share zip files between classes.

ZipFilesystem, any child filesystems created by make_sub_file_system, and any ZipStream[Write|Read] created from such a filesystem access the same physical zip file and corresponding state. If one wrote while the other read, the outcome was undefined.

This changes the code to move the zip file abstraction into a wrapper class that properly reopens files for the correct access. 

This also get's rid of the improper (and deprecated) use of the implicit copy constructor - the state was copied, but not properly shared before.

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fix_zip_filesystem/+merge/282884
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/fix_zip_filesystem into lp:widelands.