widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

The proposal to merge lp:~widelands-dev/widelands/memory_leak into lp:widelands has been updated.

Commit Message changed to:

- Fix big memory leak and extra work in UI::Table::draw.
- Fix a couple of minor memory leaks around the code I found using the Leaks tool in Apple's Instruments.
- Correctly crop destination and source rectangle while blitting.

Major leak explanation:
On each frame we created a downscaled texture if the image of a table entry was too small and leaked this texture immediately. This extra scaling work we did there was even unnecessary since OpenGL can scale down images while blitting for free.

Deleted that rescaling code, which makes the texture creation unnecessary, gets rid of the memory leak and also buys CPU cycles since a lot of work is now never done.

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/memory_leak/+merge/283690
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/memory_leak into lp:widelands.