widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Approve

One nit, otherwise lgtm.

Diff comments:

> 
> === modified file 'src/ui_basic/spinbox.cc'
> --- src/ui_basic/spinbox.cc	2016-01-01 18:41:20 +0000
> +++ src/ui_basic/spinbox.cc	2016-01-24 07:44:27 +0000
> @@ -108,7 +108,7 @@
>  	uint32_t padding = 2;
>  	uint32_t actual_w = std::max(w, unit_w);
>  	uint32_t no_padding = (is_big ? 6 : 4);
> -	uint32_t texth = UI::g_fh1->render(as_uifont("."))->height();
> +	uint32_t texth = UI::g_fh1->render(as_uifont("."))->height() + 2;

Maybe a comment about the magic 2?

>  	uint32_t buttonh = 20;
>  
>  	// 40 is an ad hoc width estimate for the MultilineTextarea scrollbar + a bit of text.


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1532279/+merge/283720
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1532279.