widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

Review: Approve code

I find update annoying and difficult too, so I'm all for it. I expect that the added CPU load won't increase for long games, so I think we can afford the extra CPU time - the recent graphics changes have already saved a lot, so we'll still be better off than we were before you started working on the graphics.

Code LGTM, just 1 question. Not tested yet.

Diff comments:

> 
> === modified file 'src/ui_basic/panel.cc'
> --- src/ui_basic/panel.cc	2016-01-27 08:06:40 +0000
> +++ src/ui_basic/panel.cc	2016-01-30 22:45:22 +0000
> @@ -150,15 +147,9 @@
>  
>  	// Panel-specific startup code. This might call end_modal()!
>  	start();
> -	g_gr->update();
>  
> -	uint32_t minTime;
> -	{
> -		int maxfps = g_options.pull_section("global").get_int("maxfps", 25);
> -		if (maxfps < 5)
> -			maxfps = 5;
> -		minTime = 1000 / maxfps;
> -	}
> +	const uint32_t minimum_frame_time =
> +	   1000 / std::max(5, g_options.pull_section("global").get_int("maxfps", 30));

Why have you changed the default form 25 to 30?

>  
>  	while (_running) {
>  		const uint32_t startTime = SDL_GetTicks();


-- 
https://code.launchpad.net/~widelands-dev/widelands/remove_update/+merge/284524
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/remove_update.