← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/remove_update into lp:widelands

 

@bunnybot merge

Diff comments:

> 
> === modified file 'src/ui_basic/panel.cc'
> --- src/ui_basic/panel.cc	2016-01-27 08:06:40 +0000
> +++ src/ui_basic/panel.cc	2016-01-30 22:45:22 +0000
> @@ -150,15 +147,9 @@
>  
>  	// Panel-specific startup code. This might call end_modal()!
>  	start();
> -	g_gr->update();
>  
> -	uint32_t minTime;
> -	{
> -		int maxfps = g_options.pull_section("global").get_int("maxfps", 25);
> -		if (maxfps < 5)
> -			maxfps = 5;
> -		minTime = 1000 / maxfps;
> -	}
> +	const uint32_t minimum_frame_time =
> +	   1000 / std::max(5, g_options.pull_section("global").get_int("maxfps", 30));

25 makes no real sense. Screens today all work on 60 Hz virtual refresh rate. We can target half of that, but everything else, but 25 is very arbitrary. I want to reach 60 eventually, but for now, 30 seems okayish.

>  
>  	while (_running) {
>  		const uint32_t startTime = SDL_GetTicks();


-- 
https://code.launchpad.net/~widelands-dev/widelands/remove_update/+merge/284524
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/remove_update.


References