widelands-dev team mailing list archive
-
widelands-dev team
-
Mailing list archive
-
Message #05775
Re: [Merge] lp:~widelands-dev/widelands/clang-codecheck into lp:widelands
My answer is in the diff
Diff comments:
>
> === modified file 'src/ai/defaultai.cc'
> --- src/ai/defaultai.cc 2016-01-24 17:01:59 +0000
> +++ src/ai/defaultai.cc 2016-02-01 11:17:20 +0000
> @@ -215,8 +215,8 @@
> }
> }
> break;
> - default:
> - ;
> + default:
> + NEVER_HERE(); // NOCOM(GunChleoc) Is this the intended behaviour here?
I think it is OK, we dont have more NoteShipMessages....
> }
> });
> }
--
https://code.launchpad.net/~widelands-dev/widelands/clang-codecheck/+merge/284586
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/clang-codecheck into lp:widelands.
References