widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Approve

The test runs and passes on travis, so I'd say this is working. Two nits, then this can go in. 

Diff comments:

> === added file 'test/maps/plain.wmf/scripting/test_text_renderer_does_not_crash.lua'
> --- test/maps/plain.wmf/scripting/test_text_renderer_does_not_crash.lua	1970-01-01 00:00:00 +0000
> +++ test/maps/plain.wmf/scripting/test_text_renderer_does_not_crash.lua	2016-02-01 17:55:33 +0000
> @@ -0,0 +1,21 @@
> +include "../data/scripting/messages.lua"
> +include "../data/scripting/formatting.lua"
> +
> +run(function()
> +   sleep(5000)
> +
> +	-- Test for <not_a_tag> in table and multilinetextarea.

indent, same for the other comment a few lines down.

> +   send_message(p1, "Title <not_a_tag>", rt(p("Some text <not_a_tag> more&nbsp;text")), {popup = true})
> +   sleep(500)
> +   send_message(p1, "Title <not_a_tag>", "Some text <not_a_tag> more&nbsp;text", {popup = true})
> +   sleep(500)
> +
> +	-- Test for <not_a_tag> in listselect and multilinetextarea.
> +   p1:add_objective("obj1", "Title 1 <not_a_tag>", rt(p("Some text <not_a_tag> more&nbsp;text")))
> +   wl.ui.MapView().buttons.objectives:click()
> +   sleep(500)
> +   p1:add_objective("obj2", "Title 2 <not_a_tag>", "Some text <not_a_tag> more&nbsp;text")
> +
> +   print("# All Tests passed.")
> +   wl.ui.MapView():close()
> +end)


-- 
https://code.launchpad.net/~widelands-dev/widelands/tags_again/+merge/284636
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/tags_again.