widelands-dev team mailing list archive
-
widelands-dev team
-
Mailing list archive
-
Message #05901
[Merge] lp:~widelands-dev/widelands/add_hint_to_map_info into lp:widelands
kaputtnik has proposed merging lp:~widelands-dev/widelands/add_hint_to_map_info into lp:widelands.
Commit message:
Add "hint" to the json file created by wl_map_info.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/add_hint_to_map_info/+merge/285228
Add the "hint" field to the json file created by wl_map_info. So it could be used on the website in the maps details page.
In other words: If someone uploads a map the hint-tag could also be shown in map details.
This was requested by king_of_nowhere and i think this is a good idea. See https://wl.widelands.org/forum/topic/1797/?page=5#post-16214
The work on the website for adding this information is going on but has to be discussed. I make a bug report on widelands-website regarding this.
--
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/add_hint_to_map_info into lp:widelands.
=== modified file 'src/logic/map_info.cc'
--- src/logic/map_info.cc 2016-01-29 13:43:56 +0000
+++ src/logic/map_info.cc 2016-02-05 18:58:49 +0000
@@ -124,6 +124,8 @@
write_string(",\n ");
write_key_value_string("description", map->get_description());
write_string(",\n ");
+ write_key_value_string("hint", map->get_hint());
+ write_string(",\n ");
write_key_value_int("width", map->get_width());
write_string(",\n ");
write_key_value_int("height", map->get_height());
Follow ups