widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/simplify_setbobdescription into lp:widelands

To: mp+285236@xxxxxxxxxxxxxxxxxx
From: GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>
Date: Sat, 06 Feb 2016 10:02:08 -0000
In-reply-to: <20160205202323.7407.6297.launchpad@ackee.canonical.com>
Reply-to: mp+285236@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Tested and code LGTM.

How about we add some more consistency in worker/production program names? e.g. we have:

check_soldier
playFX
create_bob
geologist-find

The underscores are most common, so I am in favour of renaming

playFX -> play_sound
geologist-find -> geologist_find

-- 
https://code.launchpad.net/~widelands-dev/widelands/simplify_setbobdescription/+merge/285236
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/simplify_setbobdescription.

References

[Merge] lp:~widelands-dev/widelands/simplify_setbobdescription into lp:widelands
From: SirVer, 2016-02-05