widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Disapprove

I disagree with this change. It tightly couples the child to its containing window while our UI hierarchy usually goes the other way around. Instead the Window should know that it is minimized, and therefore the children should not draw themselves automatically.

I found the issue in set_desired_size() in window.cc and proposed another fix here: https://code.launchpad.net/~widelands-dev/widelands/do_not_update_size_when_minimized/+merge/285277


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1289943/+merge/285201
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1289943.