← Back to team overview

widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/editor_help into lp:widelands

To: mp+283900@xxxxxxxxxxxxxxxxxx
From: SirVer <SirVer@xxxxxx>
Date: Sun, 07 Feb 2016 11:02:09 -0000
In-reply-to: <20160126073124.20501.95021.launchpad@ackee.canonical.com>
Reply-to: mp+283900@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Finished code review. I have some reservation about the API design in the Lua part. I think we should not rely on passing around so many strings, instead pass around the structured objects already.


-- 
https://code.launchpad.net/~widelands-dev/widelands/editor_help/+merge/283900
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/editor_help.

References

[Merge] lp:~widelands-dev/widelands/editor_help into lp:widelands
From: GunChleoc, 2016-01-26