← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/ship_and_portspaces into lp:widelands

 

Well, I work on similar issue - but not related with land ownership - all land is conquered in vicinity. Two ports in kind of bay very close to each other and it crashed when second one was finished. I found out that second port tried to place its portdock over portdock of the first port (at least partially).

The problem is in Map::find_portdock() function. Each field to be a portdock field should be tested:
a) for other immovable already there (= other portdock as we are in water)
b) ownership of such field (not problem in my case, but can be a problem in your case)

Regardless of this branch I think such check is really needed...
-- 
https://code.launchpad.net/~widelands-dev/widelands/ship_and_portspaces/+merge/285409
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ship_and_portspaces into lp:widelands.


References