← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/fix_campaign_loading into lp:widelands

 

> Why are maps not loading now? I mean, should unneeded packages not simply be
> ignored? I am afraid that some of the changes are not harmless.... but I am
> not positive.

They are not ignored, because scenarios always load all packets - scenarios use the same code path as savegames, so the dropping of unneeded packets isn't done there. I found it easier to just remove the packets than to create an extra condition in the C++ code. Less potential for new bugs ;)


> > 'data/campaigns/atl01.wmf/objective'
> 
> What is that file, actually?

No idea, the ones I removed are all empty except for a packet version number anyway. The actual campaign objectives are defined by scripting - maybe this packet is used in savegames?


> > data/campaigns/**/extra_data
> 
> I think this is needed to load the map:*.png graphic files. Not positive
> though.

I have no idea what goes in the extra_data packet either - the ones I removed only contain a packet version and nothing else. The background image for the loading screen is defined in the elemental packet, all other images (campaign messages) are loaded by the richtext code in the Lua scripts.

-- 
https://code.launchpad.net/~widelands-dev/widelands/fix_campaign_loading/+merge/285709
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fix_campaign_loading.


References