widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/network-memory into lp:widelands

To: mp+286162@xxxxxxxxxxxxxxxxxx
From: SirVer <SirVer@xxxxxx>
Date: Wed, 17 Feb 2016 07:27:58 -0000
In-reply-to: <20160216115122.6053.81896.launchpad@ackee.canonical.com>
Reply-to: mp+286162@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

I think it would be better to just always keep a vector around and just keep it empty. Dealign with new/delete for vectors is fragile, and the vector has its memory on the heap anyways, so keeping it around is basically free. 

This is only a comment though, I have no time to properly dig into the code review till the weekend.
-- 
https://code.launchpad.net/~widelands-dev/widelands/network-memory/+merge/286162
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/network-memory into lp:widelands.

References

[Merge] lp:~widelands-dev/widelands/network-memory into lp:widelands
From: GunChleoc, 2016-02-16