widelands-dev team mailing list archive

[TiborB <tiborb95@xxxxxxxxx>]

Review: Approve

Nice, I left 2 comments in diff, anyway it looks harmless and can go I think

Diff comments:

> 
> === modified file 'src/logic/map_objects/tribes/productionsite.h'
> --- src/logic/map_objects/tribes/productionsite.h	2016-02-16 13:43:48 +0000
> +++ src/logic/map_objects/tribes/productionsite.h	2016-03-10 16:23:18 +0000
> @@ -283,7 +283,7 @@
>  	InputQueues input_queues_; ///< input queues for all inputs
>  	std::vector<bool>        statistics_;
>  	uint8_t                  last_stat_percent_;
> -	uint32_t                 crude_percent_; //integer0-10000000, to be shirink to range 0-10
> +	uint32_t                 crude_percent_; // integer0-10000000, to be shirink to range 0-10

integer 0-10000000, to be divided by 10000 to get a percent, to avoid float

>  	bool                     is_stopped_;
>  	std::string              default_anim_; // normally "idle", "empty", if empty mine.
>  
> 
> === modified file 'src/sound/sound_handler.cc'
> --- src/sound/sound_handler.cc	2016-01-28 05:24:34 +0000
> +++ src/sound/sound_handler.cc	2016-03-10 16:23:18 +0000
> @@ -316,10 +316,8 @@
>  */
>  int32_t SoundHandler::stereo_position(Widelands::Coords const position)
>  {
> -	//screen x, y (without clipping applied, might well be invisible)
> +	// Screen x, y (without clipping applied, might well be invisible)
>  	int32_t sx, sy;
> -	//x, y resolutions of game window
> -	Widelands::FCoords fposition;

removing unused variable?

>  
>  	if (nosound_)
>  		return -1;


-- 
https://code.launchpad.net/~widelands-dev/widelands/codecheck-comments/+merge/288667
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/codecheck-comments.