widelands-dev team mailing list archive
-
widelands-dev team
-
Mailing list archive
-
Message #06730
[Merge] lp:~miroslavr256/widelands/bug-1550568-restool_undo_crash into lp:widelands
The proposal to merge lp:~miroslavr256/widelands/bug-1550568-restool_undo_crash into lp:widelands has been updated.
Description changed to:
The cause of this bug is dereferencing a past-the-end iterator in EditorSetResourcesTool::handle_undo_impl and setting a field's resource index to this undefined value.
In certain situations the 'increase/decrease resources' implementation can skip storing some of the old resource indices and amounts, which the undo implementation does not expect.
For more details, see:
https://code.launchpad.net/~miroslavr256/widelands/bug-1550568-restool_undo_crash/+merge/289007
--
Your team Widelands Developers is requested to review the proposed merge of lp:~miroslavr256/widelands/bug-1550568-restool_undo_crash into lp:widelands.
Follow ups