widelands-dev team mailing list archive

[Klaus Halfmann <klaus.halfmann@xxxxxxxx>]

Review: Approve

Found only renamings that are fine with me.
Copiled this and played it a while, found no anomalies.

Diff comments:

> === modified file 'src/io/filesystem/layered_filesystem.cc'
> --- src/io/filesystem/layered_filesystem.cc	2016-02-18 18:27:52 +0000
> +++ src/io/filesystem/layered_filesystem.cc	2016-03-19 10:27:47 +0000
> @@ -89,7 +89,7 @@
>  				results.insert(*fnit);
>  	}
>  
> -	for (auto it = m_filesystems.rbegin(); it != m_filesystems.rend(); ++it) {
> +	for (auto it = filesystems_.rbegin(); it != filesystems_.rend(); ++it) {
>  		files = (*it)->list_directory(path);
>  

Is this a candidate for this "auto const" optimizations?

>  		for (FilenameSet::iterator fnit = files.begin(); fnit != files.end(); ++fnit)


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-network-io-wui/+merge/289557
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1395278-network-io-wui.