← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/bug-1559729-lost_portspace into lp:widelands

 

Oops, i did not your description carefully

But at the end it really seems that during the game the code can remove some port_spaces if currently not valid. Impossible portdock is one cause, but it can be caused by buildings, trees as well - I am right? I think MapPortSpacesPacket::write should only write content of port_spaces_ without any tests. Or more specifically, it can test them if caled from editor, but not in the game... However, allows_seafaring should take care of testing them in editor instead. 




-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1559729-lost_portspace/+merge/289626
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1559729-lost_portspace into lp:widelands.


References