← Back to team overview

widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

To: mp+289782@xxxxxxxxxxxxxxxxxx
From: TiborB <tiborb95@xxxxxxxxx>
Date: Wed, 23 Mar 2016 08:39:34 -0000
In-reply-to: <20160322122221.32011.21632.launchpad@ackee.canonical.com>
Reply-to: mp+289782@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Looks nice, though I am not able to understand all the code; also I see you added regression tests - great


Anyway, somebody should compile and test it...

Approving the code
-- 
https://code.launchpad.net/~widelands-dev/widelands/lua-driven-help/+merge/289782
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/lua-driven-help.

References

[Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands
From: GunChleoc, 2016-03-22