widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

The proposal to merge lp:~widelands-dev/widelands/travis-clang-warnings into lp:widelands has been updated.

Description changed to:

Fixed some compiler warnings flagged up by clang in Travis.

Remaining warnings:

1. enumeration values not explicitly handled in switch / default label in switch which covers all enumeration values: Fixing all of these is very fiddly and doesn't necessarily generate good code. The can be helpful though and flag up real issues sometimes, so I'm OK with leaving this warning in.

2. format specifies type 'void *' but the argument has type: The same unfixable warning as in GCC. Leave it.

3. disabled expansion of recursive macro: These are triggered by a library, so we can't fix them.

4. moving a temporary object prevents copy elision / moving a local object in a return statement prevents copy elision: we have 2 of these, one in src/graphic/image_cache.cc:62:46, one in src/graphic/build_texture_atlas.cc:138:10. @SirVer: I assume you have a std::move there for efficiency, so I left them as they are.



For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/travis-clang-warnings/+merge/290697
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/travis-clang-warnings into lp:widelands.