← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/bug-1395322-tool3 into lp:widelands

 

If we're going to be so specific, we should also mention that Shift or Ctrl + Click removes map elements for Immovables, Animals and Port Space tools. Except Ctrl + Click with the Port Space tool does placement instead of removal for some reason. Perhaps we could fix this inconsistency? That would be an easy one-line change in EditorSetPortSpaceTool's constructor.

Also, see diff comments.

Diff comments:

> === modified file 'data/scripting/editor/editor_controls.lua'
> --- data/scripting/editor/editor_controls.lua	2016-04-02 08:09:19 +0000
> +++ data/scripting/editor/editor_controls.lua	2016-04-05 19:21:40 +0000
> @@ -35,6 +30,28 @@
>              -- TRANSLATORS: This is an access key combination. Localize, but do not change the key.
>              dl(help_format_hotkey(pgettext("hotkey", "Ctrl + S")), _"Save map") ..
>              help_toggle_fullscreen_hotkey()
> -         )
> +         ) ..
> +
> +         h2(_"Tools") ..
> +         p(
> +            -- TRANSLATORS: This is an access key combination. Localize, but do not change the key.
> +            dl(help_format_hotkey(pgettext("hotkey", "Click")), _"Place new elements on the map, or increase map elements by the selected value") ..
> +            -- TRANSLATORS: This is an access key combination. Localize, but do not change the key.
> +            dl(help_format_hotkey(pgettext("hotkey", "1-0")), _"Change tool size")
> +         ) ..
> +
> +         h3(_"Height and Ressources Tools") ..

Ressources -> Resources

> +         p(
> +            -- TRANSLATORS: This is an access key combination. Localize, but do not change the key.
> +            dl(help_format_hotkey(pgettext("hotkey", "Shift + Click")), _"Decrease map elements by the value selected by ‘Increase/Decrease value’") ..

Inconsistent capitalization: ‘Increase/Decrease value’ and ‘Set Value’.

> +            -- TRANSLATORS: This is an access key combination. Localize, but do not change the key.
> +            dl(help_format_hotkey(pgettext("hotkey", "Ctrl + Click")), _"Set map elements to the value selected by ‘Set Value’")
> +          ) ..
> +
> +          h3(_"Noise Height Tool") ..
> +          p(
> +            -- TRANSLATORS: This is an access key combination. Localize, but do not change the key.
> +            dl(help_format_hotkey(pgettext("hotkey", "Shift or Ctrl + Click")), _"Set height to the value selected by ‘Set Value’")
> +          )
>        )
>  }


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1395322-tool3/+merge/290829
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1395322-tool3.


References