← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/bug-1395322-tool3 into lp:widelands

 

See diff comments, otherwise LGTM.

Diff comments:

> 
> === modified file 'src/editor/ui_menus/tool_change_height_options_menu.h'
> --- src/editor/ui_menus/tool_change_height_options_menu.h	2016-04-06 09:23:04 +0000
> +++ src/editor/ui_menus/tool_change_height_options_menu.h	2016-04-07 06:07:24 +0000
> @@ -21,8 +21,9 @@
>  #define WL_EDITOR_UI_MENUS_TOOL_CHANGE_HEIGHT_OPTIONS_MENU_H
>  
>  #include "editor/ui_menus/tool_options_menu.h"
> +#include "ui_basic/box.h"
>  #include "ui_basic/button.h"

You can remove this include.

> -#include "ui_basic/textarea.h"
> +#include "ui_basic/spinbox.h"
>  
>  class EditorInteractive;
>  struct EditorIncreaseHeightTool;
> 
> === modified file 'src/editor/ui_menus/tool_noise_height_options_menu.h'
> --- src/editor/ui_menus/tool_noise_height_options_menu.h	2016-04-06 09:23:04 +0000
> +++ src/editor/ui_menus/tool_noise_height_options_menu.h	2016-04-07 06:07:24 +0000
> @@ -23,6 +23,9 @@
>  #include "editor/ui_menus/tool_options_menu.h"
>  #include "ui_basic/button.h"
>  #include "ui_basic/textarea.h"

You can remove these two includes.

> +#include "ui_basic/box.h"
> +#include "ui_basic/button.h"

And this one.

> +#include "ui_basic/spinbox.h"
>  
>  class EditorInteractive;
>  struct EditorNoiseHeightTool;


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1395322-tool3/+merge/290829
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1395322-tool3.


References