← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/revise-map-descr into lp:widelands

 

Got a crash when trying to access a folder in 'editor load map' and 'New game':

terminate called after throwing an instance of 'RT::SyntaxErrorImpl'
  what():  Syntax error at 1:65: expected an allowed tag, got 'parent'. String continues with: '<parent></font></p></rt>'

> 1. Fixed
Yeah :-)

> > 2. There are obsolete information: "Map size" and "2/3/4/... Player map".
> > These information is always in the table, so why should we have it in the
> > description again?
> 
> We also use this in Editor-> Save Map. Do you think the information is useless
> there as well? 
Yes, i think so. A mapmaker normally knows how much players he has placed on the map. The size of the map is mostly interesting when creating a new map because it has influence to max. number of players or shaping the terrain (how much unbuildable areas). And if a map is saved once, the size is shown in table. The size of the map is also shown in the Map options menu and as explained earlier i would prefer to make the Map Options  be a part of the whole Map save process (i create a bug report for this idea).
So i would say:

> b. remove the info

> 3. How is it now?
Hm, maybe better but now there is a mix of coloring headers: Mapname, yellow; String "Author", white; Name of author yellow. If we think of Headers as static strings (Name of map, "Author", "Tags"...) and other texts as variable strings (Name of Author, List of tags, Text of description,...) i think all static texts should have the same color (f.e. yellow) and all variable texts should have the same color (f.e. white). The Name of the menu is also a static text and therefor should have the same color as other static texts. I believe making a distinction like this (static/variable texts) would bring some visual order to the menu. Having two colors is really good :-)

> > Just a side note:
> 
> Good idea, but not for Build 19 ;)

Yes, of course ;) 
-- 
https://code.launchpad.net/~widelands-dev/widelands/revise-map-descr/+merge/292031
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/revise-map-descr into lp:widelands.


References